Item	File	Description	Consensus	who	status	notes
1	ParamsMgr.h	Should be derived from MyBase like all other classes in the VAPOR libraries	y		Done
2	ParamsMgr.cpp	Error reporting not performed by all class methods. (e.g. SetParams, GetParamsInstance, etc.). Documentation should indicate behavior of each method in the face of invalid arguments.	y		Done
3	vizwinmgr.cpp, regioneventrouter.cpp,   ControlExec.cpp, etc, etc.	Failure to test for error conditions returned by ParamsMgr Get* methods resulting in seg faults.	y		Done
4	ParamsMgr.h	Use const qualifiers for Get* methods wherever possible.	y		Done
5	ParamsMgr.h	Numerous methods (e.g. GetCurrentParamsInstance()) fail to check for valid inputs and behave non-deterministically in when presented with invalid arguments. E.g.  GetCurrentParamsInstance() returns undefined value if input params are invalid (uses map [] operator)	y		Done
6	ParamsMgr.h	What is difference between GetParams() and GetParamsInstance()? Document more clearly.	y		Done	no difference
7	ParamsMgr.cp	Resource mgt: DeleteVisualizerParams() and clearDummyParamsInstances() should  be testing for NULL before deleting.	y		Done
8	ParamsMgr.cpp	GetAllParamsInstances() should clear 'resultVec'. Unexpected results possible if resultVec is not empty when passed to GetAllParamsInstances()	y		Done
9	ParamsMgr.h	GetDefaultParams() modifies class if input parameter is invalid. Is this intended? If this accessor method were qualified as const the compiler would detect this.	y		Done
10	ParamsMgr.h	Document "dummy" methods	y		Done
11	ParamsMgr.cpp	Resource mgt: DeleteVisualizerParams() and clearDummyParamsInstances() should not delete memory the class didn't allocate,	n
12	paramsmgr.{cpp,h}	Name source files consistently with class name: paramsmgr -> ParamsMgr	y		Done