Date
Jul 29, 2014
Attendees
John Clyne
Scott Pearse
Goals
- Review of Params lib
Agenda
| Time | Item | Who | Notes |
|---|---|---|---|
Notes
The following changes were requested. Disposition (as of 7/29/14) is noted.
Overview doc should explain difference between Params and ParamsBase
DONE
Params: Undo and Redo are fundamental (put in docs)
DONE.
State management objects can be built with ParamsBase, give examples (put in docs)
Done
deepCopy: Why is it needed, why not use copy constructor?
The problem is that you can’t apply copy constructors to abstract classes. However the deepCopy() usage can be hidden by implementing it only at the ParamsBase level, not virtual. This way users will not need to be aware of this method. DONE.
When are we using GetNode()? This has been documented in ParamNode.h
Is ParamsBase::SetFlagDirty needed?
No. This has been removed.
Can SetChanged/HasChanged() be removed?
This has been moved down to the ViewpointParams class.
Can isPlanar() be moved to Box()?
DONE
Replace isRenderParams(), isBasicParams() with dynamic_cast
DONE.
SetLocal, IsLocal():
Add to doc an explanation. DONE
Move Containing[Stretched]BoxExtents() to Box class
DONE
Move getOrientation() to Box class ?
DONE.
Put RenderParams in its own header file.
DONE.
The Box in ArrowParams is not ever destroyed.
The problem was that the closeEvent was not triggering destruction of the Params classes. This has been fixed.
In ArrowParams: comment that default values are needed in SetValues for backwards compatibility.
DONE
Document the fact that SetValues() will call Validate().
DONE
Rename calcDataAlignment to getDataAlignment().
DONE