Date

Jan 06, 07, 2016

Notes

We reviewed the status of various items following a GUI layout review from several weeks ago GUI - Dec 3 2015, and also performed a code review on the supporting classes for the barb renderer. The recommended changes for the code review are here:

Code Review: Barb Renderer - January 6, 2016

A number of action/discussion items remain for both the GUI layout and Barb renderer code review.

A number of items were tabled for future discussion in the context of broader code reviews (e.g. interaction of ControlExec with rendering process). These items have been added the long term action list: 3.x Development Action Items

In addition to the code reviews Scott brought up an issue with the construction of the GUI layout: some of the layout is performed with .ui files via the Qt GUI designer, while other components performed programmatically by the code (e.g. the scroll bars on the subtabs). We should strive to be consistent with GUI layout construction, and only deviate when necessary (e.g. dynamic layout that needs to change at run time).

 

itemdescriptionwho
1Investigate possibility of using Qt GUI designer for components of GUI, tabs and subtabs in particular, that are implemented programmaticallyscott
2Explore making DataStatus a true class (no global scope, static methods) that can be passed to those classes that need access to it.alan
3Complete outstanding items with consensus here: Code Review: Barb Renderer - January 6, 2016 and GUI - Dec 3 2015scott, alan
4GUI usability review of animation and key framingjohn
5Analyze dynamic memory use in arrowparams.cpp and schedule follow up meetingJohn
6Investigate use of ForceRender() in render classes (e.g. arrowrenderer) in the context of a overall GUI architecture design review that includes the control execjohn